rdblue commented on code in PR #12139:
URL: https://github.com/apache/iceberg/pull/12139#discussion_r1943539725
##########
core/src/main/java/org/apache/iceberg/variants/Variants.java:
##########
@@ -209,59 +213,59 @@ public static VariantPrimitive<Void> ofNull() {
return new PrimitiveWrapper<>(PhysicalType.NULL, null);
}
- static VariantPrimitive<Boolean> of(boolean value) {
+ public static VariantPrimitive<Boolean> of(boolean value) {
Review Comment:
I think that we're going to want these in order to be able to construct
variants anyway, so I'm inclined to leave them as public, at least in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
