danielcweeks commented on code in PR #12139:
URL: https://github.com/apache/iceberg/pull/12139#discussion_r1941577496
##########
parquet/src/main/java/org/apache/iceberg/parquet/PruneColumns.java:
##########
@@ -162,9 +168,11 @@ private Integer getId(Type type) {
return type.getId() == null ? null : type.getId().intValue();
}
- private boolean isStruct(Type field) {
+ private boolean isStruct(Type field, NestedField expected) {
if (field.isPrimitive()) {
return false;
+ } else if (expected.type() ==
org.apache.iceberg.types.Types.VariantType.get()) {
Review Comment:
Here's another case where I feel like the `Type:isVariantType` would make
things more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
