Fokko commented on PR #12169:
URL: https://github.com/apache/iceberg/pull/12169#issuecomment-2633771511
@jbonofre I strongly feel we're overindexing on this one. A separate
NOTICE/LICENSE makes sense for the fat JARs that we produce, but I don't think
we want a separate jar for the `{core/api/common}`.
> For instance, presto is only in for spark. Maybe we should consider
license/notice in each jar where it makes sense and fallback on empty/default
one.
Are you referring to this one?
```
This product includes code from Presto.
* Retry wait and jitter logic in Tasks.java
* S3FileIO logic derived from PrestoS3FileSystem.java in S3InputStream.java
and S3OutputStream.java
* SQL grammar rules for parsing CALL statements in IcebergSqlExtensions.g4
* some aspects of handling stored procedures
Copyright: 2016 Facebook and contributors
Home page: https://prestodb.io/
License: https://www.apache.org/licenses/LICENSE-2.0
```
- `Tasks.java` is part of `core`
- `S3{InputStream,OutputStream}` of `aws`
- `IcebergSqlExtensions.g4` part of Spark
I'm afraid that moving everything into separate `NOTICES` and `LICENSE` will
make it a nightmare to maintain because for the bundles we have to combine them
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
