szehon-ho commented on code in PR #12115: URL: https://github.com/apache/iceberg/pull/12115#discussion_r1938207738
########## docs/docs/spark-procedures.md: ########## @@ -972,4 +972,91 @@ CALL catalog_name.system.compute_table_stats(table => 'my_table', snapshot_id => Collect statistics of the snapshot with id `snap1` of table `my_table` for columns `col1` and `col2` ```sql CALL catalog_name.system.compute_table_stats(table => 'my_table', snapshot_id => 'snap1', columns => array('col1', 'col2')); -``` \ No newline at end of file +``` + +## Table Replication + +The `rewrite-table-path` assists in moving or copying an Iceberg table from one location to another. + +### `rewrite-table-path` + +This procedure writes a new copy of the Iceberg table's metadata files where every path has had its prefix replaced. Review Comment: 1. Can we drop 'this procedure'? I think its implied, the other ones do not have it. 2. 'has had' is a mouthful. How about 'every absolute path source prefix is replaced to the specified target prefix' (going along the javadoc) 3. Misspell 'coping' in next sentence. How about again going with javadoc? This can be the starting point to fully or incrementally copy an Iceberg table located under an absolute path under a source prefix to another under the target prefix. 4. Is there a need to call out explicitly that it retains snapshot history, schema, partition stats? I would lean towards not having it, as the list could be big here. TLDR: ``` Stages a copy of the Iceberg table's metadata files where every absolute path source prefix is replaced to the specified target. This can be the starting point to fully or incrementally copy an Iceberg table located under an absolute path under a source prefix to another under the target prefix. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org