Re: [PR] automate building Release Candidate in github action [iceberg-python]

[via GitHub]

Fokko commented on code in PR #1391:
URL: https://github.com/apache/iceberg-python/pull/1391#discussion_r1938574146


##########
mkdocs/docs/how-to-release.md:
##########
@@ -109,66 +109,81 @@ Create a signed tag:
 Replace `VERSION` and `RC` with the appropriate values for the release.
 
 ```bash
-export RC=rc1
-export VERSION=0.7.0${RC}
-export VERSION_WITHOUT_RC=${VERSION/rc?/}
-export VERSION_BRANCH=${VERSION_WITHOUT_RC//./-}
-export GIT_TAG=pyiceberg-${VERSION}
+export VERSION=0.7.0
+export RC=1
 
-git tag -s ${GIT_TAG} -m "PyIceberg ${VERSION}"
+export VERSION_WITH_RC=${VERSION}rc${RC}
+export GIT_TAG=pyiceberg-${VERSION_WITH_RC}
+
+git tag -s ${GIT_TAG} -m "PyIceberg ${VERSION_WITH_RC}"
 git push g...@github.com:apache/iceberg-python.git ${GIT_TAG}
 ```
 
-### Publish Release Candidate (RC)
+### Create Artifacts
 
-#### Upload to Apache Dev SVN
+The [`Python Build Release Candidate` Github 
Action](https://github.com/apache/iceberg-python/actions/workflows/python-release.yml)
 will run automatically upon tag push.
 
-##### Create Artifacts for SVN
+This action will generate artifacts that will include both source distribution 
(`sdist`) and binary distributions (`wheels` using 
[`cibuildwheel`](https://github.com/pypa/cibuildwheel)) for each architectures.
 
-Run the [`Python release` Github 
Action](https://github.com/apache/iceberg-python/actions/workflows/python-release.yml).
+This action will generate two final artifacts:
 
-* Tag: Use the newly created tag.
-* Version: Set the `version` to `main`, as the source cannot be modified.
+* `svn-release-candidate-${VERSION}rc${RC}` for SVN
+* `pypi-release-candidate-${VERSION}rc${RC}` for PyPi
 
-![Github Actions Run Workflow for SVN 
Upload](assets/images/ghactions-run-workflow-svn-upload.png)
+If `gh` is available, watch the GitHub Action progress using:

Review Comment:
   Love it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org