kevinjqliu commented on code in PR #1391:
URL: https://github.com/apache/iceberg-python/pull/1391#discussion_r1938564633
##########
.github/workflows/python-release.yml:
##########
@@ -17,29 +17,192 @@
# under the License.
#
-name: "Python Release"
+name: "Python Build Release Candidate"
on:
+ push:
+ tags:
+ # Trigger this workflow when tag follows the versioning format:
pyiceberg-<major>.<minor>.<patch>rc<release_candidate>
+ # Example valid tags: pyiceberg-0.8.0rc2, pyiceberg-1.0.0rc1
+ - 'pyiceberg-[0-9]+.[0-9]+.[0-9]+rc[0-9]+'
workflow_dispatch:
inputs:
version:
- description: 'Version'
+ description: 'Version (e.g., 0.8.0)'
type: string
- default: 'main'
-
+ required: true
+ rc:
+ description: 'Release Candidate (RC) (e.g., 1)'
+ type: number
+ required: true
jobs:
- build_wheels:
- name: Build wheels on ${{ matrix.os }}
+ validate-inputs:
+ runs-on: ubuntu-latest
+ outputs:
+ VERSION: ${{ steps.validate-inputs.outputs.VERSION }} # e.g. 0.8.0
+ RC: ${{ steps.validate-inputs.outputs.RC }} # e.g. 1
+ steps:
+ - name: Validate and Extract Version and RC
+ id: validate-inputs
+ run: |
+ if [ "$GITHUB_EVENT_NAME" = "push" ]; then
+ echo "Workflow triggered by tag push."
Review Comment:
yep the `else` branch on L60 handles the workflow-dispatch part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
