gaborkaszab commented on PR #12132: URL: https://github.com/apache/iceberg/pull/12132#issuecomment-2626634873
Another issue I found with the current approach is that if `write.metadata.delete-after-commit.enabled` is true we just keep a certain number of metadata.jsons for a table, controlled by `write.metadata.previous-versions-max`. So even if we iterate through the previous metadata files, there could easily be ones that are not part of the 'previousFiles' list. @lliangyu-lin But in general, since the fix for this issue is not straightforward, I recommend you to start a [DISCUSS] thread on dev@ mail list. I found that questions there usually have more visibility than on PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
