ebyhr commented on code in PR #12132:
URL: https://github.com/apache/iceberg/pull/12132#discussion_r1934928382


##########
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java:
##########
@@ -129,6 +130,81 @@ public void dropTableDataDeletesExpectedFiles() throws 
IOException {
         .containsAll(partitionStatsLocations);
   }
 
+  @Test
+  public void dropTableDataDeletesAllPuffinFiles() throws IOException {

Review Comment:
   Puffin is used for deletion vectors in V3 sepc. It would be nice to rename 
the test to `...StatsFiles` if it doesn't contain DV.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to