wypoon commented on code in PR #12106: URL: https://github.com/apache/iceberg/pull/12106#discussion_r1932732786
########## api/src/main/java/org/apache/iceberg/RemoveMissingFiles.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +/** + * API for deleting files from a table. This is intended for use in removing missing files, both + * {@link DataFile data files} and {@link DeleteFile delete files}. + * + * <p>This API accumulates file deletions, produces a new {@link Snapshot} of the table, and commits + * that snapshot as the current. + * + * <p>When committing, these changes will be applied to the latest table snapshot. Commit conflicts + * will be resolved by applying the changes to the new latest snapshot and reattempting the commit. + */ +public interface RemoveMissingFiles extends SnapshotUpdate<RemoveMissingFiles> { + /** + * Delete a file tracked by a {@link DataFile} from the underlying table. + * + * @param file a DataFile to remove from the table + * @return this for method chaining + */ + RemoveMissingFiles deleteFile(DataFile file); Review Comment: The implementation of `DeleteFiles::deleteFile(CharSequence)` calls `MergingSnapshotProducer::deleteFile(CharSequence)`: ``` protected void delete(CharSequence path) { // this is an old call that never worked for delete files and can only be used to remove data // files. filterManager.delete(path); } ``` It cannot be used to remove delete files, only data files. It is better not to call `delete(CharSequence)`, where you have no guarantees on what kind of file the path is for. It is better to call only `delete(DataFile)` and `delete(DeleteFile)`. Therefore it makes sense to have that as the API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
