wypoon commented on PR #12106: URL: https://github.com/apache/iceberg/pull/12106#issuecomment-2619848304
I am open to better naming for the new API. I want to support removing both delete and data files, so I cannot use `DeleteFiles`. See [DataOperations.DELETE](https://github.com/apache/iceberg/blob/61241ed4789e719237d276a08fc3cc4113b312c0/api/src/main/java/org/apache/iceberg/DataOperations.java#L52-L57): ``` /** * Data is deleted from the table and no data is added. * * <p>This operation is implemented by {@link DeleteFiles}. */ public static final String DELETE = "delete"; ``` and [StreamingDelete::operation()](https://github.com/apache/iceberg/blob/61241ed4789e719237d276a08fc3cc4113b312c0/core/src/main/java/org/apache/iceberg/StreamingDelete.java#L36-L39): ``` @Override protected String operation() { return DataOperations.DELETE; } ``` Removing delete files will undelete deleted rows, i.e., add data. When data is both deleted and added, the data operation is `OVERWRITE`. `RowDelta` can be used for `OVERWRITE` operations -- it is intended for row-level deletes and updates -- but it is not well-suited to this use case and using it can lead to validation errors that I do not want to deal with. Therefore I introduce a new API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
