sungwy commented on PR #1569: URL: https://github.com/apache/iceberg-python/pull/1569#issuecomment-2617807935
Thanks for working on this PR @lloyd-EA and thank you @kevinjqliu for the review. Could I add another suggestion to read the table using Spark and verify that the value that's been read is equal to the expected value? As I mentioned in a comment in https://github.com/apache/iceberg-python/issues/1045#issuecomment-2617788267 I think it would be great to verify that the data is readable as `us` timestamp through a Spark session as well. Here's an example that uses a spark session for reference: https://github.com/apache/iceberg-python/blob/985029042199d870f25b6fbec0e80907d4440f41/tests/integration/test_add_files.py#L183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
