paleolimbot commented on issue #33: URL: https://github.com/apache/iceberg-cpp/issues/33#issuecomment-2613988183
> I found it is super lightweight and convenient to simply use the bundled nanoarrow.hpp and nanoarrow.cc files generated by ci/scripts/bundle.py --cpp --symbol-namespace=iceberg --output-dir /tmp/bundled. That's what we like to hear! We also support CMake via `FetchContent` and `find_package()` and meson/wrapdb if any of those are easier 🙂. > (perhaps sparrow passing the cross-implementation integration tests should be a first milestone before considering it) https://github.com/man-group/sparrow/issues/306 I believe is tracking this one! All this being said, I think that you want: > 2. Use ArrowArray from the [Arrow C data interface](https://arrow.apache.org/docs/format/CDataInterface.html#structure-definitions) and users are free to use their own Arrow implementations. ...so that you don't have to force your users to pin a nanoarrow or sparrow version. I don't personally expose `nanoarrow.h` in any projects I use it in (the interface is always in terms of `ArrowArrayStream`). FWIW I also think sparrow is great! We in theory could add more C++ to nanoarrow.hpp too, but there hasn't been much of an appetite to contribute or review (and with some macros and the RAII helpers in nanoarrow.hpp, it's verbose but not bad to just use the C library). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
