jbonofre commented on code in PR #12052: URL: https://github.com/apache/iceberg/pull/12052#discussion_r1926463235
########## azure-bundle/LICENSE: ########## @@ -511,9 +511,3 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens Group: org.reactivestreams Name: reactive-streams Version: 1.0.4 Project URL: http://www.reactive-streams.org/ License: MIT-0 - https://spdx.org/licenses/MIT-0.html - --------------------------------------------------------------------------------- - -Group: org.slf4j Name: slf4j-api Version: 1.7.36 Review Comment: I don't think we can consider https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/logging/Slf4JLogger.java as slf4j-api provided. It's different package/class. The Netty `NOTICE` (https://github.com/netty/netty/blob/4.1/NOTICE.txt) mentions slf4j: ``` This product contains a modified portion of 'SLF4J', a simple logging facade for Java, which can be obtained at: * LICENSE: * license/LICENSE.slf4j.txt (MIT License) * HOMEPAGE: * https://www.slf4j.org/ ``` That should be in our `NOTICE` (I will update the `NOTICE` in this PR). So, strictly speaking, the Slf4jLogger is not provided by slf4j-api. I still think that we should remove slf4-api from `LICENSE` because `org.slf4j*` is not bundle. ########## aws-bundle/LICENSE: ########## @@ -297,12 +297,6 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -------------------------------------------------------------------------------- -Group: org.slf4j Name: slf4j-api Version: 1.7.36 -Project URL: http://www.slf4j.org Review Comment: I don't think we can consider https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/logging/Slf4JLogger.java as slf4j-api provided. It's different package/class. The Netty `NOTICE` (https://github.com/netty/netty/blob/4.1/NOTICE.txt) mentions slf4j: ``` This product contains a modified portion of 'SLF4J', a simple logging facade for Java, which can be obtained at: * LICENSE: * license/LICENSE.slf4j.txt (MIT License) * HOMEPAGE: * https://www.slf4j.org/ ``` That should be in our `NOTICE` (I will update the `NOTICE` in this PR). So, strictly speaking, the Slf4jLogger is not provided by slf4j-api. I still think that we should remove slf4-api from `LICENSE` because `org.slf4j*` is not bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
