Fokko commented on code in PR #12052: URL: https://github.com/apache/iceberg/pull/12052#discussion_r1926395983
########## azure-bundle/LICENSE: ########## @@ -511,9 +511,3 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens Group: org.reactivestreams Name: reactive-streams Version: 1.0.4 Project URL: http://www.reactive-streams.org/ License: MIT-0 - https://spdx.org/licenses/MIT-0.html - --------------------------------------------------------------------------------- - -Group: org.slf4j Name: slf4j-api Version: 1.7.36 Review Comment: ``` ➜ cp /Users/fokko.driesprong/work/iceberg/azure-bundle/build/libs/iceberg-azure-bundle-1.8.0-SNAPSHOT.jar . ➜ unzip iceberg-azure-bundle-1.8.0-SNAPSHOT.jar ➜ find . | grep -i slf ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLogger.class ./reactor/util/Loggers$Slf4JLoggerFactory.class ./reactor/util/Loggers$Slf4JLogger.class ``` ########## aws-bundle/LICENSE: ########## @@ -297,12 +297,6 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -------------------------------------------------------------------------------- -Group: org.slf4j Name: slf4j-api Version: 1.7.36 -Project URL: http://www.slf4j.org Review Comment: ``` ➜ iceberg git:(main) ls -lah aws-bundle/build/libs total 100584 drwxr-xr-x 6 fokko.driesprong staff 192B Jan 23 06:33 . drwxr-xr-x 5 fokko.driesprong staff 160B Jan 23 06:33 .. -rw-r--r-- 1 fokko.driesprong staff 6.1K Jan 23 06:33 iceberg-aws-bundle-1.8.0-SNAPSHOT-javadoc.jar -rw-r--r-- 1 fokko.driesprong staff 6.1K Jan 23 06:33 iceberg-aws-bundle-1.8.0-SNAPSHOT-sources.jar -rw-r--r-- 1 fokko.driesprong staff 6.1K Jan 23 06:33 iceberg-aws-bundle-1.8.0-SNAPSHOT-tests.jar -rw-r--r-- 1 fokko.driesprong staff 49M Jan 23 06:33 iceberg-aws-bundle-1.8.0-SNAPSHOT.jar ➜ aws-bundle cp /Users/fokko.driesprong/work/iceberg/aws-bundle/build/libs/iceberg-aws-bundle-1.8.0-SNAPSHOT.jar . ➜ aws-bundle ls iceberg-aws-bundle-1.8.0-SNAPSHOT.jar ➜ aws-bundle unzip iceberg-aws-bundle-1.8.0-SNAPSHOT.jar ➜ aws-bundle find . | grep -i slf ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLogger.class ``` ########## gcp-bundle/LICENSE: ########## @@ -549,12 +549,6 @@ License: Apache 2 - https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -Group: org.slf4j Name: slf4j-api Version: 1.7.36 Review Comment: ``` ➜ cp /Users/fokko.driesprong/work/iceberg/gcp-bundle/build/libs/iceberg-gcp-bundle-1.8.0-SNAPSHOT.jar . ➜ unzip iceberg-gcp-bundle-1.8.0-SNAPSHOT.jar ➜ find . | grep -i slf ./io/grpc/netty/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class ./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class ./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class ./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLogger.class ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
