Fokko commented on code in PR #1555:
URL: https://github.com/apache/iceberg-python/pull/1555#discussion_r1926067731
##########
pyiceberg/partitioning.py:
##########
@@ -413,8 +413,10 @@ def partition_record_value(partition_field:
PartitionField, value: Any, schema:
the final partition record value.
"""
iceberg_type =
schema.find_field(name_or_id=partition_field.source_id).field_type
- iceberg_typed_value = _to_partition_representation(iceberg_type, value)
- transformed_value =
partition_field.transform.transform(iceberg_type)(iceberg_typed_value)
+ if not isinstance(value, int):
+ # When adding files, it can be that we still need to convert from
logical types to physical types
+ value = _to_partition_representation(iceberg_type, value)
+ transformed_value =
partition_field.transform.transform(iceberg_type)(value)
Review Comment:
> also if its just for adding files, perhaps we can do something special
just for that path
Yes, that's exactly what I went for. I think we can simplify the logic in
subsequent PRs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
