kevinjqliu commented on code in PR #1555:
URL: https://github.com/apache/iceberg-python/pull/1555#discussion_r1924080871
##########
tests/integration/test_writes/test_partitioned_writes.py:
##########
@@ -1126,3 +1127,25 @@ def test_append_multiple_partitions(
"""
)
assert files_df.count() == 6
+
+
+@pytest.mark.integration
+def test_pyarrow_overflow(session_catalog: Catalog) -> None:
+ """Test what happens when the offset is beyond 32 bits"""
+ identifier = "default.arrow_table_overflow"
+ try:
+ session_catalog.drop_table(identifier=identifier)
+ except NoSuchTableError:
+ pass
+
+ x = pa.array([random.randint(0, 999) for _ in range(30_000)])
Review Comment:
i wonder if random here is making the test non-deterministic. since we're
testing the overflow, what if we just use `999` or do `random.randint(900, 999)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
