zeroshade commented on code in PR #265:
URL: https://github.com/apache/iceberg-go/pull/265#discussion_r1925619803
##########
catalog/catalog.go:
##########
@@ -144,6 +150,7 @@ type options struct {
sigv4Service string
prefix string
authUri *url.URL
+ scope *string
Review Comment:
could this be a string and not a pointer? just use the zero-value (empty
string) to indicate that we should use the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
