liurenjie1024 commented on PR #895: URL: https://github.com/apache/iceberg-rust/pull/895#issuecomment-2606814519
> > Is it possible to take [datafusion_sqllogictest](https://github.com/apache/datafusion/blob/e9a77e0ea3e30b7f2718c9cea1fed023dca1f646/datafusion/sqllogictest/Cargo.toml#L33) as a dependency instead of copying over the code? > > +1 on this. It seems we don't need any customization (except for `ctx.register_catalog`) on the test driver, so it's not economical to maintain a copy. cc @alamb for opinions. We could also consider use a git dependency for now. I have concerns as using a git dependency, with this approach datafusion community is not treating it as a library. I'm quite interested if datafusion community could consider exposing it as a crate. I've raised [discussion](https://github.com/apache/datafusion/discussions/14229), welcome to discuss there! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
