liurenjie1024 commented on code in PR #892: URL: https://github.com/apache/iceberg-rust/pull/892#discussion_r1925017095
########## crates/iceberg/src/puffin/reader.rs: ########## @@ -0,0 +1,126 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::io::{FileRead, InputFile}; +use crate::puffin::blob::Blob; +use crate::puffin::metadata::{BlobMetadata, FileMetadata}; +use crate::Result; + +/// Puffin reader +pub(crate) struct PuffinReader { + input_file: InputFile, + file_metadata: Option<FileMetadata>, +} + +impl PuffinReader { + /// Returns a new Puffin reader + pub(crate) fn new(input_file: InputFile) -> Self { + Self { + input_file, + file_metadata: None, + } + } + + /// Returns file metadata + pub(crate) async fn file_metadata(&mut self) -> Result<&FileMetadata> { Review Comment: Should we consider using a `LazyLock` to initalize it? This way it could be thread safe, and discard the `&mut` modifier. ########## crates/iceberg/src/puffin/blob.rs: ########## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; + +/// A serialized form of a "compact" Theta sketch produced by the Apache DataSketches library. +pub(crate) const APACHE_DATASKETCHES_THETA_V1: &str = "apache-datasketches-theta-v1"; + +/// The blob +#[derive(Debug, PartialEq, Clone)] +pub(crate) struct Blob { + /// See blob types: https://iceberg.apache.org/puffin-spec/#blob-types + pub(crate) r#type: String, + /// List of field IDs the blob was computed for; the order of items is used to compute sketches stored in the blob. + pub(crate) fields: Vec<i32>, + /// ID of the Iceberg table's snapshot the blob was computed from + pub(crate) snapshot_id: i64, + /// Sequence number of the Iceberg table's snapshot the blob was computed from + pub(crate) sequence_number: i64, + /// The actual blob data + pub(crate) data: Vec<u8>, Review Comment: Should we add comment to explain that this is always uncompressed data? ########## crates/iceberg/src/puffin/reader.rs: ########## @@ -0,0 +1,126 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::io::{FileRead, InputFile}; +use crate::puffin::blob::Blob; +use crate::puffin::metadata::{BlobMetadata, FileMetadata}; +use crate::Result; + +/// Puffin reader +pub(crate) struct PuffinReader { + input_file: InputFile, + file_metadata: Option<FileMetadata>, +} + +impl PuffinReader { + /// Returns a new Puffin reader + pub(crate) fn new(input_file: InputFile) -> Self { + Self { + input_file, + file_metadata: None, + } + } + + /// Returns file metadata + pub(crate) async fn file_metadata(&mut self) -> Result<&FileMetadata> { + if let Some(ref file_metadata) = self.file_metadata { + Ok(file_metadata) + } else { + let file_metadata = FileMetadata::read(&self.input_file).await?; + Ok(self.file_metadata.insert(file_metadata)) + } + } + + /// Returns blob + pub(crate) async fn blob(&self, blob_metadata: BlobMetadata) -> Result<Blob> { Review Comment: ```suggestion pub(crate) async fn blob(&self, blob_metadata: &BlobMetadata) -> Result<Blob> { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
