aokolnychyi commented on code in PR #11675:
URL: https://github.com/apache/iceberg/pull/11675#discussion_r1924424811
##########
core/src/main/java/org/apache/iceberg/MetadataColumns.java:
##########
@@ -92,6 +92,20 @@ private MetadataColumns() {}
Types.LongType.get(),
"Commit snapshot ID");
+ // the content size and offset of a DV
Review Comment:
I wouldn't necessarily bind these fields to DVs. They can make sense for
other use cases in the future. Also, they do seem more like metadata columns to
me, rather than reserved columns. This class defines both.
The `position_deletes` metadata table uses `FILE_PATH_COLUMN_ID`, which is a
metadata column. I'd probably define these field IDs as metadata and just give
names to them in `PositionDeletesTable`. I see the content size and offset used
together with the file name records come from. If `FILE_PATH_COLUMN_ID` is part
of the schema, it means these columns should probably be included statically as
well (instead of being projected like real metadata columns).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
