amogh-jahagirdar commented on code in PR #11808:
URL: https://github.com/apache/iceberg/pull/11808#discussion_r1890997488
##########
core/src/main/java/org/apache/iceberg/MetadataColumns.java:
##########
@@ -92,6 +92,20 @@ private MetadataColumns() {}
Types.LongType.get(),
"Commit snapshot ID");
+ // the content size and offset of a DV
Review Comment:
super nit, "the content offset and size of a DV" (just because the fields
are initialized in that order)
##########
core/src/main/java/org/apache/iceberg/MetadataColumns.java:
##########
@@ -92,6 +92,20 @@ private MetadataColumns() {}
Types.LongType.get(),
"Commit snapshot ID");
+ // the content size and offset of a DV
+ public static final NestedField CONTENT_OFFSET =
+ Types.NestedField.optional(
+ Integer.MAX_VALUE - 107,
+ "content_offset",
+ Types.LongType.get(),
+ "The offset in the DV where the content starts");
+ public static final NestedField CONTENT_SIZE_IN_BYTES =
+ Types.NestedField.optional(
+ Integer.MAX_VALUE - 108,
+ "content_size_in_bytes",
+ Types.LongType.get(),
+ "The length in bytes of referenced content stored in a DV");
Review Comment:
"The length in bytes of the DV blob" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
