liurenjie1024 commented on PR #895: URL: https://github.com/apache/iceberg-rust/pull/895#issuecomment-2601473466
> This follows the [datafusion/datafusion/sqllogictest](https://github.com/apache/datafusion/blob/e9a77e0ea3e30b7f2718c9cea1fed023dca1f646/datafusion/sqllogictest/src/engines/datafusion_engine/runner.rs#L122-L124) tests suite. Do you think its worth mentioning that [conversion.rs](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/src/engines/conversion.rs#L26) and [normalize.rs](https://github.com/apache/datafusion/blob/e9a77e0ea3e30b7f2718c9cea1fed023dca1f646/datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs) are both copied over from datafusion/datafusion/sqllogictest? I've synced with @Fokko and I'll add some notice in LICENSE as what we did in [pyiceberg](https://github.com/apache/iceberg-python/blob/f0346472e4301f2ea3679e0793bb8623f2bb80f1/LICENSE#L206). > Is it possible to take [datafusion_sqllogictest](https://github.com/apache/datafusion/blob/e9a77e0ea3e30b7f2718c9cea1fed023dca1f646/datafusion/sqllogictest/Cargo.toml#L33) as a dependency instead of copying over the code? Currently impossible because it's not published as crates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
