kevinjqliu commented on issue #1439: URL: https://github.com/apache/iceberg-python/issues/1439#issuecomment-2583675951
> have we ever considered taking an approach similar (at a high-level, of course - some details don't transfer over to Python) to the Java-side that has [CatalogTests](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java)? Yes thats a great idea. The REST TCK (Technology Compatibility Kit) was merged recently https://github.com/apache/iceberg/pull/10908 The idea is to point it at a REST server and check its behavior against the REST API spec. So we can test the pyiceberg rest catalog implementation against the catalog tests from the java side. > I noticed a bunch of duplication between Glue and Dynamo integration testing [here](https://github.com/apache/iceberg-python/blob/main/tests/catalog/integration_test_glue.py#L257-L355) and [here](https://github.com/apache/iceberg-python/blob/main/tests/catalog/integration_test_dynamodb.py#L149-L247) respectively that made me wonder why there aren't tests on a PyIceberg Catalog that can be run against them all. I think this is a separate but important issue for pyiceberg. I want a set of tests which can be based off the catalog base class. The idea is to make it easier for new catalogs to test the base behaviors. This would be helpful for `S3TablesCatalog` (#1429). I had #813 open to track something like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
