smaheshwar-pltr commented on issue #1439: URL: https://github.com/apache/iceberg-python/issues/1439#issuecomment-2582725070
(New to PyIceberg, so just spitballing here 😄) @kevinjqliu, have we ever considered taking an approach similar (at a high-level, of course - some details don't transfer over to Python) to the Java-side that has [`CatalogTests`](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java)? This is a base integration test class; various Catalog implementations have integration tests that override it (with additional tests if needed and some disabled). It can also be wired up with a REST Catalog. In this way, a bunch of expected Catalog behaviours can be verified with various catalogs (and REST wiring can be checked too). I noticed a bunch of duplication between Glue and Dynamo integration testing [here](https://github.com/apache/iceberg-python/blob/main/tests/catalog/integration_test_glue.py#L257-L355) and [here](https://github.com/apache/iceberg-python/blob/main/tests/catalog/integration_test_dynamodb.py#L149-L247) respectively that made me wonder why there aren't tests on a PyIceberg `Catalog` that can be run against them all. Happy to open a separate issue if this makes sense to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
