aokolnychyi commented on PR #11704: URL: https://github.com/apache/iceberg/pull/11704#issuecomment-2583301296
I would also be in favor of making the views immutable to prevent modifications and fixing equals/hashCode similar to what we did in https://github.com/apache/iceberg/pull/9245. What's weird right now is that we allow modifications to the views but they are not propagated back to the map. I think it will be reasonable to throw an exception instead and document the behavior. I agree that building custom maps/sets correctly is not easy and we could have debated that more prior to adding them. That said, the remaining contract deviations are rather minor and/or can be fixed. I don't think it would be worth to go this route and remove custom sets/maps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
