rdblue commented on PR #11704: URL: https://github.com/apache/iceberg/pull/11704#issuecomment-2578783272
I'm in favor of documenting these differences and moving on. I think the utility of the Map interface is worth it, and I don't think that the minor issues, like not being able to modify the map by calling `remove` on the key set is significant. Aren't we already returning an immutable or unmodifiable key set anyway? Also, the issue with map equality is present in the comparator-based maps as well. When you don't use `equals` for keys then you get that behavior. I think that documenting it is the easiest and best solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
