DevChrisCross commented on PR #1498: URL: https://github.com/apache/iceberg-python/pull/1498#issuecomment-2578661029
@kevinjqliu Ah yes I've noticed that part as well, I've initially placed on the `primitive` because based on my understanding, it traverses through the `schema` until it reaches the `primitive` part, and thus, it makes sense to me to also place the code and the error message to the same place where the actual data type checking is being done :) I've just utilized the existing functionality here in `visit_pyarrow` with `StructTypes` where it puts the field name, before doing the check and if indeed applicable, to the data type being processed, and removes it also afterwards, making it feasible for me to work on and giving some sort of guarantee when the code is working with "fields". https://github.com/apache/iceberg-python/blob/3b580111760f0749922ea593dbe0b1d602952438/pyiceberg/io/pyarrow.py#L964-L968 I'm not sure if I'm missing out regarding on how the `field` method is being utilized by `PyArrowSchemaVisitor` classes if I ever place it there? It doesn't make much that sense to me at the moment, I hope you could point me to the right direction :) Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
