kevinjqliu commented on code in PR #1498:
URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1907568373
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1140,6 +1147,12 @@ def map(self, map_type: pa.MapType, key_result:
IcebergType, value_result: Icebe
return MapType(key_id, key_result, value_id, value_result,
value_required=not value_field.nullable)
def primitive(self, primitive: pa.DataType) -> PrimitiveType:
+ field_name = None
+ unsupported_prefix = "Unsupported"
+ if len(self._field_names) > 0:
+ field_name = self._field_names[-1]
+ unsupported_prefix = f"Column '{field_name}' has an unsupported"
+
Review Comment:
I'm not sure if this is the right place to do this.
The `primitive` function here only knows the underlying pyarrow data type
(`pa.DataType`) and nothing about the field/field_name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
