RussellSpitzer commented on PR #11906: URL: https://github.com/apache/iceberg/pull/11906#issuecomment-2575979132
The test here says it's failling because youare deleting ``` but the following elements were unexpected: ["file:/tmp/junit-14563533605645158466/data/_c2_trunc/subfolder/file.txt", "file:/tmp/junit-14563533605645158466/data/_c2_trunc/file.txt"] ``` When those are not files that are traditionally removed by remove orphan files (which only removes files with certain prefixes.) This is a behavior change and I don't think it's actually beneficial so is there any way to fix this? ```TestRemoveOrphanFilesAction3 > testHiddenPathsStartingWithPartitionNamesAreIgnored() > formatVersion = 3 FAILED java.lang.AssertionError: [same as] Expecting actual: ["file:/tmp/junit-14563533605645158466/metadata/v1.metadata.json", "file:/tmp/junit-14563533605645158466/metadata/v2.metadata.json", "file:/tmp/junit-14563533605645158466/metadata/2607cb5e-4b09-49d3-8887-52a5341aaaa9-m0.avro", "file:/tmp/junit-14563533605645158466/metadata/version-hint.text", "file:/tmp/junit-14563533605645158466/metadata/snap-1334501503484114515-1-2607cb5e-4b09-49d3-8887-52a5341aaaa9.avro", "file:/tmp/junit-14563533605645158466/data/_c2_trunc/subfolder/file.txt", "file:/tmp/junit-14563533605645158466/data/_c2_trunc/file.txt", "file:/tmp/junit-14563533605645158466/data/_c2_trunc=AA/c3=AAAA/00000-864-80ba5c39-c3da-4be3-9783-5d8666c89ccc-0-00001.parquet"] to contain exactly in any order: ["file:/tmp/junit-14563533605645158466/metadata/v1.metadata.json", "file:/tmp/junit-14563533605645158466/metadata/v2.metadata.json", "file:/tmp/junit-14563533605645158466/metadata/2607cb5e-4b09-49d3-8887-52a5341aaaa9-m0.avro", "file:/tmp/junit-14563533605645158466/metadata/version-hint.text", "file:/tmp/junit-14563533605645158466/metadata/snap-1334501503484114515-1-2607cb5e-4b09-49d3-8887-52a5341aaaa9.avro", "file:/tmp/junit-14563533605645158466/data/_c2_trunc=AA/c3=AAAA/00000-864-80ba5c39-c3da-4be3-9783-5d8666c89ccc-0-00001.parquet"] but the following elements were unexpected: ["file:/tmp/junit-14563533605645158466/data/_c2_trunc/subfolder/file.txt", "file:/tmp/junit-14563533605645158466/data/_c2_trunc/file.txt"] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org