ismailsimsek commented on code in PR #11906:
URL: https://github.com/apache/iceberg/pull/11906#discussion_r1903264071
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -610,9 +613,12 @@ public void
testHiddenPathsStartingWithPartitionNamesAreIgnored() throws IOExcep
waitUntilAfter(System.currentTimeMillis());
SparkActions actions = SparkActions.get();
+ DeleteOrphanFilesSparkAction action =
+ actions.deleteOrphanFiles(table).olderThan(System.currentTimeMillis());
+ // test list methods by directly instantiating the action
+ assertThatDatasetsAreEqualIgnoringOrder(action.listWithPrefix(),
action.listWithoutPrefix());
Review Comment:
Not sure how to fix this test! one option is to extend `listPrefix`
interface and give it additional `PathFilter` argument.
example with
[PathFilter](https://hadoop.apache.org/docs/r3.0.0/api/org/apache/hadoop/fs/PathFilter.html):
`table.io().listPrefix(location, pathFilter)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
