felixscherz commented on code in PR #1429: URL: https://github.com/apache/iceberg-python/pull/1429#discussion_r1905875973
########## tests/catalog/test_s3tables.py: ########## @@ -0,0 +1,227 @@ +import pytest Review Comment: I renamed it to `integration_test_s3tables.py` and also changed the S3 table bucket arn environment variable to `AWS_TEST_S3_TABLE_BUCKET_ARN` to be more explicit, similar to glue: https://github.com/apache/iceberg-python/blob/main/tests/conftest.py#L2090-L2092 Tests are now run with ```bash AWS_REGION=us-east-2 AWS_TEST_S3_TABLE_BUCKET_ARN=... poetry run pytest tests/catalog/integration_test_s3tables.py ``` I'll adjust the PR description. Let me know what you think:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
