bryanck commented on code in PR #11883:
URL: https://github.com/apache/iceberg/pull/11883#discussion_r1900479843
##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/IntegrationMultiTableTest.java:
##########
@@ -20,55 +20,27 @@
import static org.assertj.core.api.Assertions.assertThat;
-import java.time.Duration;
import java.time.Instant;
import java.util.List;
import org.apache.iceberg.DataFile;
-import org.apache.iceberg.Table;
-import org.apache.iceberg.catalog.Namespace;
-import org.apache.iceberg.catalog.SupportsNamespaces;
-import org.apache.iceberg.catalog.TableIdentifier;
-import org.awaitility.Awaitility;
-import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.NullSource;
import org.junit.jupiter.params.provider.ValueSource;
public class IntegrationMultiTableTest extends IntegrationTestBase {
- private static final String TEST_DB = "test";
- private static final String TEST_TABLE1 = "foobar1";
- private static final String TEST_TABLE2 = "foobar2";
- private static final TableIdentifier TABLE_IDENTIFIER1 =
TableIdentifier.of(TEST_DB, TEST_TABLE1);
- private static final TableIdentifier TABLE_IDENTIFIER2 =
TableIdentifier.of(TEST_DB, TEST_TABLE2);
-
- @BeforeEach
- public void before() {
- createTopic(testTopic(), TEST_TOPIC_PARTITIONS);
- ((SupportsNamespaces) catalog()).createNamespace(Namespace.of(TEST_DB));
- }
-
- @AfterEach
- public void after() {
- context().stopConnector(connectorName());
- deleteTopic(testTopic());
- catalog().dropTable(TableIdentifier.of(TEST_DB, TEST_TABLE1));
- catalog().dropTable(TableIdentifier.of(TEST_DB, TEST_TABLE2));
- ((SupportsNamespaces) catalog()).dropNamespace(Namespace.of(TEST_DB));
- }
-
@ParameterizedTest
@NullSource
@ValueSource(strings = "test_branch")
public void testIcebergSink(String branch) {
// partitioned table
catalog().createTable(TABLE_IDENTIFIER1, TestEvent.TEST_SCHEMA,
TestEvent.TEST_SPEC);
- // unpartitioned table
+ // non-partitioned table
Review Comment:
We use "unpartitioned" throughout the Iceberg code, so please revert this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
