wombatu-kun opened a new pull request, #11883: URL: https://github.com/apache/iceberg/pull/11883
I've found a lot of code duplicates in integration tests of module `iceberg-kafka-connect-runtime`. I propose to avoid such code duplication by making parent class `IntegrationTestBase` abstract and move all common logic (beforeEach, afterEach, creating kafka common config, running test, asserting snapshot is added) from `IntegrationTest`, `IntegrationMultiTableTest` and `IntegrationDynamicTableTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
