lidavidm commented on PR #20: URL: https://github.com/apache/iceberg-cpp/pull/20#issuecomment-2566143404
I think it's a security issue: the `write` permission doesn't discriminate between who opened the PR or where you can write to, so someone could open a malicious PR to write to the repository. pre-commit only runs clang-format, not clang-tidy - I think it'd still be useful even without the PR comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
