gruuya commented on code in PR #825: URL: https://github.com/apache/iceberg-rust/pull/825#discussion_r1893147477
########## crates/integration_tests/testdata/pyiceberg/load_types_table.py: ########## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from datafusion import SessionContext +from pyiceberg.catalog import load_catalog +import pyarrow.parquet as pq + +# Generate a table with various types in memory and dump to a Parquet file +ctx = SessionContext() Review Comment: Alright just an update—I've tried doing the same with pyspark but it seems it is being very conservative and either rejecting some types outright (e.g. `Illegal Parquet type: INT64 (TIMESTAMP(NANOS,false))`), or coercing them on its own. For instance if I just supply it with a Parquet file like `type_test.parquet` (output of `load_types_table.py`) with type hints ``` message arrow_schema { optional boolean cboolean; optional int32 cint8 (INTEGER(8,true)); optional int32 cint16 (INTEGER(16,true)); optional int32 cint32; optional int64 cint64; ... ``` and do ```python parquet_df = spark.read.parquet("types_test.parquet") parquet_df.writeTo("rest.default.types_test").using("iceberg").create() ``` the resulting data parquet files have incompatible type hints removed ``` message table { optional boolean cboolean = 1; optional int32 cint8 = 2; optional int32 cint16 = 3; optional int32 cint32 = 4; optional int64 cint64 = 5; ... ``` TLDR: I can't seem to replicate the issue in #814 with pyspark, though it could still be used to test out the non-corner cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
