kevinjqliu commented on code in PR #825: URL: https://github.com/apache/iceberg-rust/pull/825#discussion_r1893092640
########## crates/integration_tests/testdata/pyiceberg/load_types_table.py: ########## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from datafusion import SessionContext +from pyiceberg.catalog import load_catalog +import pyarrow.parquet as pq + +# Generate a table with various types in memory and dump to a Parquet file +ctx = SessionContext() Review Comment: Generally i like the idea of using `pyiceberg` for testing, maybe also alongside spark. This can help facilitate cross platform interoperability, but im not sure when we would use one versus the other. ########## crates/integration_tests/testdata/pyiceberg/Dockerfile: ########## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM python:3.9-bullseye + +RUN pip install pyiceberg==0.8 pyarrow==18.0 datafusion==43.1.0 Review Comment: nit: for `pyarrow`, use `pyiceberg[pyarrow]` instead. ########## crates/integration_tests/testdata/pyiceberg/load_types_table.py: ########## Review Comment: nit: wdyt of renaming this `provision.py` mirroring what we do for the spark setup https://github.com/apache/iceberg-rust/blob/main/crates/integration_tests/testdata/spark/provision.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
