kevinjqliu commented on code in PR #1443:
URL: https://github.com/apache/iceberg-python/pull/1443#discussion_r1892693244
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1237,16 +1238,29 @@ def _task_to_record_batches(
# When V3 support is introduced, we will update
`downcast_ns_timestamp_to_us` flag based on
# the table format version.
file_schema = pyarrow_to_schema(physical_schema, name_mapping,
downcast_ns_timestamp_to_us=True)
+
+ if file_schema is None:
Review Comment:
i think so `pyarrow_to_schema` should return a `Schema` object, not `None`
https://github.com/apache/iceberg-python/blob/1278e8880c4767287dc69208ced20bd444c37228/pyiceberg/io/pyarrow.py#L848-L850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
