smaheshwar-pltr commented on code in PR #11798:
URL: https://github.com/apache/iceberg/pull/11798#discussion_r1888502532
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -244,7 +244,7 @@ private TableProperties() {}
public static final String OBJECT_STORE_ENABLED =
"write.object-storage.enabled";
public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
- // Excludes the partition values in the path when set to true and object
store is enabled
+ // Excludes the partition values in the path when set to false and object
store is enabled
Review Comment:
Hmm, I feel like this suggested wording could be misinterpreted as "object
store must be enabled for partition values to be included" (but [default
location provision includes partition
values](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/LocationProviders.java#L98)),
just as this PR's proposed wording could be read as, "to exclude partition
values, you should disable this property and enable object store" (which is
correct, modulo custom location provision).
I agree that a comment on when the property is true reads better but this
PR's wording seems the least misunderstandable IMHO.
@ebyhr @amogh-jahagirdar @nastra thank you for reviewing - let me know your
thoughts! Happy to be overruled here and make the suggested change if I'm being
too pedantic, or to take other suggestions 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
