jiakai-li commented on code in PR #1423:
URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1885864835
##########
pyiceberg/table/__init__.py:
##########
@@ -268,12 +268,10 @@ def _apply(self, updates: Tuple[TableUpdate, ...],
requirements: Tuple[TableRequ
return self
- def _scan(self, row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE)
-> DataScan:
+ def _scan(self, row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE,
case_sensitive: bool = True) -> DataScan:
Review Comment:
Thanks Fokko :-) I've updated the PR to adjust the `case_sensitive` argument
position to the end and closed the other comments. But I might need some more
guidance regarding this one.
My understanding is this `Transaction._scan` method does not relate to the
`TableScan` class. It seems a helper method only used by the
`Transaction.delete` method to return a `DataScan` object, and the
`Transaction.delete` method now takes the new `case_sensitive` and use it to
pass it over to plan files. I can modify the `Transaction.delete` method to use
`DataScan` directly in order to pass `case_sensitive`, but that would then make
this `Transaction._scan` redundant and can be removed. Should I do it this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
