nastra commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1883809126
########## core/src/test/java/org/apache/iceberg/rest/TestHTTPHeaders.java: ########## @@ -95,6 +100,9 @@ void addIfAbsentHTTPHeader() { "header1", List.of("value1a", "value1b"), "header2", List.of("value2"), "header3", List.of("value3"))); + + assertThatThrownBy(() -> headers.addIfAbsent((HTTPHeaders) null)) + .isInstanceOf(NullPointerException.class); Review Comment: checks like this should always have a `.hasMessage` check to make sure we get the right error msg back (unfortunately we can't easily enforce such a rule via checkstyle) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org