nastra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1876060020
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -549,25 +555,47 @@ private static void commitTransaction(Catalog catalog,
CommitTransactionRequest
transactions.forEach(Transaction::commitTransaction);
}
- public <T extends RESTResponse> T execute(
+ HTTPRequest buildRequest(
HTTPMethod method,
String path,
Map<String, String> queryParams,
- Object body,
- Class<T> responseType,
Map<String, String> headers,
- Consumer<ErrorResponse> errorHandler) {
+ Object body) {
+ URI baseUri = URI.create("https://localhost:8080";);
+ ObjectMapper mapper = RESTObjectMapper.mapper();
Review Comment:
this is already the default mapper, so can be omitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
