adutra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1876226734
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -200,77 +123,6 @@ private RESTClient httpClient() {
return httpClient;
}
- private AuthSession authSession() {
- String token = token().get();
- if (null != token) {
Review Comment:
Ah OK 👍
To create a signer this way, you need to:
* Reimplement `S3FileIOProperties` or extend it and override
`applySignerConfiguration()`;
* Reimplement `S3FileIO` or extend it and override the constructor and
`initialize(Map<String,String)` since `S3FileIOProperties` is hard-coded in
these places.
So... I don't think this is a realistic scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
