pvary commented on code in PR #11513: URL: https://github.com/apache/iceberg/pull/11513#discussion_r1876635103
########## core/src/main/java/org/apache/iceberg/actions/FileRewriteGroup.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import java.util.Comparator; +import java.util.List; +import org.apache.iceberg.ContentFile; +import org.apache.iceberg.ContentScanTask; +import org.apache.iceberg.RewriteJobOrder; + +/** + * Container class representing a set of files to be rewritten by a {@link FileRewriteExecutor}. Review Comment: The current code makes sure that the exact same compaction result is generated than with the previous algorithm. In the old code we had: - Plan level - writeMaxFileSize - which governs the target file size when rewriting (SparkWriteOptions.TARGET_FILE_SIZE_BYTES) - Group level - splitSize - which governs the input split size when rewriting (SparkReadOptions.SPLIT_SIZE, splitSize)] - expectedOutputFiles - which governs the shuffle partition numbers for shuffling rewriters In the new code I have mirrored this. I think the new code would be much cleaner if we put all of this information into the group level (we could get rid of the `initPlan` step) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
