pvary commented on code in PR #11513: URL: https://github.com/apache/iceberg/pull/11513#discussion_r1876417391
########## core/src/main/java/org/apache/iceberg/actions/FileRewriteExecutor.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import java.util.Map; +import java.util.Set; +import org.apache.iceberg.ContentFile; +import org.apache.iceberg.ContentScanTask; + +/** + * A class for rewriting content file groups ({@link FileRewriteGroup}). + * + * @param <I> the Java type of the plan info + * @param <T> the Java type of the tasks to read content files + * @param <F> the Java type of the content files + * @param <G> the Java type of the planned groups + * @param <P> the Java type of the plan to execute + */ +public interface FileRewriteExecutor< + I, + T extends ContentScanTask<F>, + F extends ContentFile<F>, + G extends FileRewriteGroup<I, T, F>, + P extends FileRewritePlan<I, T, F, G>> { + + /** Returns a description for this rewriter. */ + default String description() { + return getClass().getName(); + } + + /** + * Returns a set of supported options for this rewriter. Only options specified in this list will + * be accepted at runtime. Any other options will be rejected. + */ + Set<String> validOptions(); + + /** + * Initializes this rewriter using provided options. + * + * @param options options to initialize this rewriter + */ + void init(Map<String, String> options); Review Comment: Will add javadoc. - `init` is called when the executor is initialized - `initPlan` is called when the plan has been generated and the parameters needed for the executor is calculated (`writeMaxFileSize`, `outputSpecId`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
