szehon-ho commented on PR #11555: URL: https://github.com/apache/iceberg/pull/11555#issuecomment-2524803591
@flyrain thanks for review! I spent some time cleaning it up. Now more things are moved to RewriteTablePathsUtil, removing the need to make ManifestLists public. Also , I moved the rewrite of position deletes into a spark job. It took me a bit of time to realize, I need to actually rewrite the delete entry's bounds as well (before because I rewrote the position delete file inline, the bounds were correctly populated, but now I have to fix them because the delete file is rewritten later). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
