kevinjqliu commented on code in PR #1389:
URL: https://github.com/apache/iceberg-python/pull/1389#discussion_r1870106562
##########
pyiceberg/catalog/rest.py:
##########
@@ -887,7 +887,7 @@ def table_exists(self, identifier: Union[str, Identifier])
-> bool:
if response.status_code == 404:
return False
- elif response.status_code == 204:
+ elif response.status_code in (200, 204):
Review Comment:
https://github.com/apache/iceberg-python/issues/1363#issuecomment-2497462825
##########
pyiceberg/catalog/rest.py:
##########
@@ -887,7 +887,7 @@ def table_exists(self, identifier: Union[str, Identifier])
-> bool:
if response.status_code == 404:
return False
- elif response.status_code == 204:
+ elif response.status_code in (200, 204):
Review Comment:
should we upstream this to the spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
