sungwy commented on PR #1389: URL: https://github.com/apache/iceberg-python/pull/1389#issuecomment-2517606943
@Fokko - it looks like the issue is because the rest-fixture is returning a 200 response. I've put in edits to allow PyIceberg to infer a 200 response as being successful. The proposed solution deviates from the [REST Catalog Spec](https://github.com/apache/iceberg/blob/c7cef9bd81d150108a56a848b7482f179ea878b8/open-api/rest-catalog-open-api.yaml#L1691-L1699), but this is already the behavior of PyIceberg when handles the success codes of the other endpoints that are also meant to return 204 response: https://github.com/apache/iceberg-python/blob/df804c4c65033039ef16bb9a51c68aebfb010e5e/pyiceberg/catalog/rest.py#L422-L448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
