IzzelAliz commented on code in PR #11690:
URL: https://github.com/apache/iceberg/pull/11690#discussion_r1869400659
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -237,15 +237,15 @@ Path getMetadataFile(int metadataVersion) throws
IOException {
for (TableMetadataParser.Codec codec : TABLE_METADATA_PARSER_CODEC_VALUES)
{
Path metadataFile = metadataFilePath(metadataVersion, codec);
FileSystem fs = getFileSystem(metadataFile, conf);
- if (fs.exists(metadataFile)) {
+ if (fs.isFile(metadataFile)) {
Review Comment:
s3a has [specialized
implementation](https://github.com/apache/hadoop/blob/b55c9c7495a7da6a50082259ffd143cb8c1ee424/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java#L5048)
of `isFile` that only use headobject. If we switch to `getFileStatus` then
this PR become non sense.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
