adutra commented on code in PR #10753: URL: https://github.com/apache/iceberg/pull/10753#discussion_r1869092873
########## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ########## @@ -81,14 +71,12 @@ public abstract class S3V4RestSignerClient private static final String SCOPE = "sign"; @SuppressWarnings("immutables:incompat") - private static volatile ScheduledExecutorService tokenRefreshExecutor; + // FIXME auth manager is not properly closed Review Comment: Do you mind if we do that in a follow-up PR? I can work on it immediately after this one is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org