adutra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1869011306
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java:
##########
@@ -47,7 +47,7 @@ default String scope() {
return OAuth2Properties.CATALOG_SCOPE;
}
- @Value.Lazy
+ @Value.Default
Review Comment:
The only difference is that with `@Lazy` there will be no builder method
generated for that attribute, effectively making it a read-only/derived
property. With `@Default`, it's a separate property with its own builder method
– but the same default initial value.
I think `@Default` makes more sense here, because we do have a property
`TOKEN_EXPIRES_IN_MS` that users can set, so it would be optimal if the user
value could be reflected here.
But I don't want to fight for this: if you prefer we can revert back to
`@Lazy`, in which case the `TOKEN_EXPIRES_IN_MS` property would have to be
stored somewhere else, outside of this class. No big deal.
I will leave the final word to any of you @nastra or @danielcweeks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
